The vB Geek

Go Back   The vB Geek > vB Geek Commons > Lizard Lounge

Lizard Lounge The place to post off topic stuff.

Advertisement
  Learn how to remove ads

Reply
 
Thread Tools Display Modes
  #1  
Old 08-25-2005, 11:41 PM
KTBleeding KTBleeding is offline
Member
 
Join Date: Aug 2005
Posts: 89
Geek Article and Review System License Holder GeekMart License Holder Geek Auto-Linker Pro License Holder 
Default Valid XHTML for Geek Products?

Hey, I'm just curious where you stand on this.
I hate to be the annoying guy who asks, but I've become pretty picky with this to be honest.

I know, and agree that the main priority will be getting it released. But I'd be willing to help make the templates valid XHTML if needed.

Who knows, you may already have this implemented.. I'm at work, so I haven't been able to check out out further than the W3 validator (which could be reporting errors from this vB style).
Reply With Quote
  #2  
Old 08-25-2005, 11:42 PM
The Geek's Avatar
The Geek The Geek is offline
Senior Member
 
Join Date: Aug 2005
Posts: 6,717
Geek Article and Review System License Holder GeekMart License Holder Geek Auto-Linker Pro License Holder Geek Advertising Banner License Holder Geek Gazette License Holder 
Default

Hey - Im no HTML guy... If you can point out tags that are pissing off the validators - I am more than chuffed to sirt em!
Reply With Quote
  #3  
Old 08-26-2005, 01:40 AM
KTBleeding KTBleeding is offline
Member
 
Join Date: Aug 2005
Posts: 89
Geek Article and Review System License Holder GeekMart License Holder Geek Auto-Linker Pro License Holder 
Default

Cool.

I've been taking a jab at it here and I'm stuck on the view cart, which I'm hoping you can help me with:

The problem is with this code,
HTML Code:
<input type="text" size="10" id="items[$itemkey]" name="items[$itemkey]" value="$item[qty]" />
In the template gmart_cart_item

Apparently, the [ character is not allowed in the id location (though name and value seem to have no problem with it)

Any ideas?
Reply With Quote
  #4  
Old 08-26-2005, 08:22 AM
The Geek's Avatar
The Geek The Geek is offline
Senior Member
 
Join Date: Aug 2005
Posts: 6,717
Geek Article and Review System License Holder GeekMart License Holder Geek Auto-Linker Pro License Holder Geek Advertising Banner License Holder Geek Gazette License Holder 
Default

Nope

Thats how you pass an array via post.

Image you ordered 1 license and 1 installation of geekmart . Since they are both on the same page, it would get posted as:
$_POST['items'][0]=License - yes
$_POST['items'][1]=Installation - yes
$_POST['items'][0]=Renewal - no!

Are you running the template code through the validator or the final pages? I would think that the template code wont validate for a number of reasons - then again Im no html freak
Reply With Quote
  #5  
Old 08-26-2005, 02:03 PM
KTBleeding KTBleeding is offline
Member
 
Join Date: Aug 2005
Posts: 89
Geek Article and Review System License Holder GeekMart License Holder Geek Auto-Linker Pro License Holder 
Default

Well, so far I've only done the view cart section. I just did it by that one page and edited all of the templates that were used.
Reply With Quote
  #6  
Old 08-26-2005, 02:21 PM
The Geek's Avatar
The Geek The Geek is offline
Senior Member
 
Join Date: Aug 2005
Posts: 6,717
Geek Article and Review System License Holder GeekMart License Holder Geek Auto-Linker Pro License Holder Geek Advertising Banner License Holder Geek Gazette License Holder 
Default

youve edited the templates!?!

Let me know what changes were made so I can roll them into the next release.

Thanks!
Reply With Quote
  #7  
Old 08-26-2005, 03:52 PM
KTBleeding KTBleeding is offline
Member
 
Join Date: Aug 2005
Posts: 89
Geek Article and Review System License Holder GeekMart License Holder Geek Auto-Linker Pro License Holder 
Default

Sure thing. I've only done the two for view cart so far, but here they are:

gmart_view_cart
HTML Code:
<form action="$vbphrase[gmart_script].php" method="post">
<input type="hidden" name="do" id="do" value="updatecart" />
	<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
	<thead>
		<tr>
			<td class="tcat" colspan="4">
				<a style="float:$stylevar[right];white-space: nowrap;" href="#top" onclick="return toggle_collapse('gmart_product_items')"><img id="collapseimg_gmart_product_items" src="$stylevar[imgdir_button]/collapse_tcat$vbcollapse[collapseimg_gmart_product_items].gif" alt="" border="0" /></a>
				$vbphrase[gmart_your_cart]
			</td>
		</tr>
	</thead>
	<tbody id="collapseobj_gmart_product_items" style="$vbcollapse[collapseobj_gmart_product_items]">
	<if condition="$item_bits">
	<tr>
		<td class="thead" align="left">
			$vbphrase[gmart_item]
		</td>
		<td class="thead" align="right">
			$vbphrase[gmart_price]
		</td>
		<td class="thead" align="center">
			$vbphrase[gmart_qty]
		</td>
		<td class="thead" align="right">
			$vbphrase[gmart_ext_price]
		</td>
	</tr>
	$item_bits
	</tbody>
	</table>
					
	$total_bits
	<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
	<thead>
		<tr>
			<td class="tcat">
				<a style="float:$stylevar[right];white-space: nowrap;" href="#top" onclick="return toggle_collapse('gmart_cart_options')"><img id="collapseimg_gmart_cart_options" src="$stylevar[imgdir_button]/collapse_tcat$vbcollapse[collapseimg_gmart_cart_options].gif" alt="" border="0" /></a>
				$vbphrase[gmart_your_cart]
			</td>
		</tr>
	</thead>
	<tbody id="collapseobj_gmart_cart_options" style="$vbcollapse[collapseobj_gmart_cart_options]">
	<tr>
		<td class="alt1">
			$vbphrase[gmart_cart_instructions]
		</td>
	</tr>
	<tr>
		<td class="thead" align="center">
			<input type="submit" class="button" name="submit" id="submit" value="Update" />
			<input type="submit" class="button" name="checkout" id="checkout" value="Checkout" />
		</td>
	</tr>
	</tbody>
	</table>
</form>
	<else />
	<tr>
		<td class="alt1" colspan="4" align="center">
			$vbphrase[gmart_cart_empty]
		</td>
	</tr>
	</tbody>
	</table>
</form>
</if>
<br />
gmart_cart_item
HTML Code:
<tr>
	<td class="alt1" align="left">
		<a href="$vbphrase[gmart_script].php?$session[sessionurl]do=displayproduct&amp;id=$item[productid]">$item[title]</a>
	</td>
	<td class="alt1" align="right" width="100px">
		$pp[symbol] $item[price]
	</td>
	<td class="alt2" align="center" width="100px">
		<input type="text" size="10" id="items[$itemkey]" name="items[$itemkey]" value="$item[qty]" />
	</td>
	<td class="alt1" align="right" width="100px">
	$pp[symbol] $item[extprice]
	</td>
</tr>
That eliminates 11 of the 12 errors that were there. I'll let you know when I figure out the whole [ error.
Reply With Quote
  #8  
Old 08-26-2005, 04:01 PM
The Geek's Avatar
The Geek The Geek is offline
Senior Member
 
Join Date: Aug 2005
Posts: 6,717
Geek Article and Review System License Holder GeekMart License Holder Geek Auto-Linker Pro License Holder Geek Advertising Banner License Holder Geek Gazette License Holder 
Default

thanks man
Reply With Quote
  #9  
Old 08-26-2005, 04:15 PM
KTBleeding KTBleeding is offline
Member
 
Join Date: Aug 2005
Posts: 89
Geek Article and Review System License Holder GeekMart License Holder Geek Auto-Linker Pro License Holder 
Default

No problem.

Actually, Geek.
How important is it that id="items[$itemkey]" is included?
I removed it from the template and it now validates as XHTML.

The cart items also update when putting them in, so it looks like it still functions well.
Reply With Quote
  #10  
Old 08-26-2005, 04:16 PM
The Geek's Avatar
The Geek The Geek is offline
Senior Member
 
Join Date: Aug 2005
Posts: 6,717
Geek Article and Review System License Holder GeekMart License Holder Geek Auto-Linker Pro License Holder Geek Advertising Banner License Holder Geek Gazette License Holder 
Default

Very important when you have more than 1 item on a page.
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Downloadable products? Caesar GeekMart 3 09-03-2008 02:32 AM
using INDENT not valid for vbadvanced nymyth Geek Article and Review System 7 07-03-2007 10:06 PM
valid GAL entry joh Geek Auto-Linker 20 10-25-2006 07:28 PM
Which products Bridges Lizard Lounge 2 10-11-2006 12:11 AM
a question regarding xhtml tpr Lizard Lounge 3 10-21-2005 06:28 PM


All times are GMT. The time now is 07:43 AM.


Powered by vBulletin® Version 3.8.5
Copyright ©2000 - 2017, Jelsoft Enterprises Ltd.