The vB Geek

Go Back   The vB Geek > vB Geek Products > Geek Article and Review System

Geek Article and Review System GARS is the mega popular system for turning forums into articles, tutorials, or even reviews.

Advertisement
  Learn how to remove ads

Reply
 
Thread Tools Display Modes
  #1  
Old 05-18-2007, 02:15 AM
Chris-777 Chris-777 is offline
Junior Member
 
Join Date: May 2007
Location: Boston, MA
Posts: 18
Geek Article and Review System License Holder 
Default W3 validation problems galore

I'm having a few odd issues, which I'll try and sort out and post fixes for here.

This code:

Code:
name="gars_container_2"
Quote:
Originally Posted by validator.w3.org
You have used the attribute named above in your document, but the document type you are using does not support that attribute for this element. This error is often caused by incorrect use of the "Strict" document type with a document that uses frames (e.g. you must use the "Transitional" document type to get the "target" attribute), or by using vendor proprietary extensions such as "marginheight" (this is usually fixed by using CSS to achieve the desired effect instead).

This error may also result if the element itself is not supported in the document type you are using, as an undefined element will have no supported attributes; in this case, see the element-undefined error message for further information.
Next, the alt text for a featured review insert inside another review doesn't seem to properly have alt text defined.

Here's the page in question, one of many, that was perfectly compliant before converting it to GARS:

http://www.sevenstring.org/forum/art...t-kroeker.html

Now it has errors galore.

Last edited by Chris-777; 05-18-2007 at 03:14 AM..
Reply With Quote
  #2  
Old 05-18-2007, 02:23 AM
Chris-777 Chris-777 is offline
Junior Member
 
Join Date: May 2007
Location: Boston, MA
Posts: 18
Geek Article and Review System License Holder 
Default

Also, the way styles are inserted is invalid. I can't even validate my base article listing.

Code:
# <style>
# .gars_sub {
# padding:0px 0px 0px 50px;
# margin: 0;
# list-style-type: none;
# }
# .gars_sub li {
# display: block;
# }
# </style>
"required attribute "type" not specified."

Quote:
The attribute given above is required for an element that you've used, but you have omitted it. For instance, in most HTML and XHTML document types the "type" attribute is required on the "script" element and the "alt" attribute is required for the "img" element.
You can fix this one by changing the opening style tag to:

Code:
<style type="text/css">
In the GARS_forumdisplay template.

Last edited by Chris-777; 05-18-2007 at 02:55 AM..
Reply With Quote
  #3  
Old 05-18-2007, 02:29 AM
Chris-777 Chris-777 is offline
Junior Member
 
Join Date: May 2007
Location: Boston, MA
Posts: 18
Geek Article and Review System License Holder 
Default

Fixed the first error by removing:

Code:
name="gars_container_$itemid"
From the GARS_mod_container template. This is absurd, I can't believe I have to go line by line and template by template through a $40 modification to fix this many basic validation errors.

Code:
id="threadslist"
This also appears WAY too many times, since you can only declare an ID once. I've just removed a handful of them from GARS_forumdisplay.

Last edited by Chris-777; 05-18-2007 at 02:33 AM..
Reply With Quote
  #4  
Old 05-18-2007, 02:42 AM
Chris-777 Chris-777 is offline
Junior Member
 
Join Date: May 2007
Location: Boston, MA
Posts: 18
Geek Article and Review System License Holder 
Default

I'm at a total loss right now, so I suppose I'll end this with a question.

Validate this forum:

http://www.sevenstring.org/forum/art...ws-interviews/

The alt text is incorrect for the inset review block. I've no idea where to set it, because it just pops up "Read More", and I can't find the GARS_read_more phrase in any templates. The more featured articles you have, the more W3 errors you will get.

I also need to know where to change the "About Managing Articles & Posts" text, so that I can properly put in the code for the & symbol instead of just sticking it in there, because (suprise!) that's invalid too.

This is a great modification, but honestly for a paid mod, I am very, very disappointed right now that someone would charge for something with this many errors. I'll venture to say that GARS is, presently, rather bad for SEO for otherwise compliant sites.

Edit: I found how to edit in the alt text.

In geek\mods\display\featured.php, this line (line 91):

Code:
$bits .= "<td align='center'><a href='showthread.php?t=$value[threadid]' title='$vbphrase[GARS_read_more]' style='text-decoration:none;'><img src='$value[image]' style='border-style: solid;border-color: #000000;padding:2px;' /><br /><strong>$value[title]</strong></a><br />$value[byline]</td>";
Needs to be changed to this:

Code:
                $bits .= "<td align='center'><a href='showthread.php?t=$value[threadid]' title='$vbphrase[GARS_read_more]' style='text-decoration:none;'><img alt=\"Read More\" src='$value[image]' style='border-style: solid;border-color: #000000;padding:2px;' /><br /><strong>$value[title]</strong></a><br />$value[byline]</td>";
I had to add in the:

Code:
alt=\"Read More\"
Escaping the quotes. Add that in and at least one relatively big validation error will go away.

Last edited by Chris-777; 05-18-2007 at 02:52 AM..
Reply With Quote
  #5  
Old 05-18-2007, 08:22 AM
The Geek's Avatar
The Geek The Geek is offline
Senior Member
 
Join Date: Aug 2005
Posts: 6,717
Geek Article and Review System License Holder GeekMart License Holder Geek Auto-Linker Pro License Holder Geek Advertising Banner License Holder Geek Gazette License Holder 
Default

I have started reworking the styles to merge the 3.6.7 changes in and this is something Ill look at - however with all this disapointment, you may want to opt for another mod and I will refund your license.
Reply With Quote
  #6  
Old 05-18-2007, 01:58 PM
Chris-777 Chris-777 is offline
Junior Member
 
Join Date: May 2007
Location: Boston, MA
Posts: 18
Geek Article and Review System License Holder 
Default

Apologies for the smug tone, I was just a bit worn out after spending a handful of hours digging around for fixes.

I love the system, and I'll happily post up any fixes that I can come across getting it to be compliant. I'd just like a hand here and there pointing out where things are.
Reply With Quote
  #7  
Old 05-20-2007, 10:23 PM
Chris-777 Chris-777 is offline
Junior Member
 
Join Date: May 2007
Location: Boston, MA
Posts: 18
Geek Article and Review System License Holder 
Default

Addition:

In the template GARS_comment, after:

Code:
<!-- message -->
            <div>$post[message]</div>
<!-- / message -->
Add:

Code:
</td>
Also, in GARS_Forumdisplay, GARS_simple_pb and GARS_pb you need to add alt text to each instance of clear.gif.

Last edited by Chris-777; 05-20-2007 at 10:27 PM..
Reply With Quote
  #8  
Old 05-20-2007, 10:29 PM
Chris-777 Chris-777 is offline
Junior Member
 
Join Date: May 2007
Location: Boston, MA
Posts: 18
Geek Article and Review System License Holder 
Default

Also, in all three instances of the phrase GARS_thread_title, the & symbol needs to be changed to:

Code:
&amp;

Last edited by Chris-777; 05-20-2007 at 10:31 PM..
Reply With Quote
  #9  
Old 05-20-2007, 10:38 PM
Chris-777 Chris-777 is offline
Junior Member
 
Join Date: May 2007
Location: Boston, MA
Posts: 18
Geek Article and Review System License Holder 
Default

In GARS_Forumdisplay, there's a trailing extra /if:

Right under:

Code:
<!-- ############## END THREADS LIST ##############  -->
Kill the extra /if.
Reply With Quote
  #10  
Old 05-21-2007, 12:49 AM
strike3forumsmh strike3forumsmh is offline
Junior Member
 
Join Date: Jun 2006
Posts: 14
Geek Article and Review System License Holder Geek Gazette License Holder 
Default

This is some fantastic work here Chris, I am hoping to make these changes as soon as I can.

Thanks!
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Problems.... AzzidReign Geek Gazette 8 01-02-2009 08:41 AM
A couple of HTML validation questions mreyes Geek Article and Review System 2 10-15-2008 02:51 PM
CSS validation errors! Milad Geek Article and Review System 3 05-29-2008 03:04 PM
Forum display problems & rating problems gldtn Geek Article and Review System 1 12-20-2006 08:32 AM
Regarding Validation Michael Lizard Lounge 1 10-07-2005 10:05 AM


All times are GMT. The time now is 09:50 PM.


Powered by vBulletin® Version 3.8.5
Copyright ©2000 - 2017, Jelsoft Enterprises Ltd.