The vB Geek

Go Back   The vB Geek > vB Geek Products > Geek Article and Review System

Geek Article and Review System GARS is the mega popular system for turning forums into articles, tutorials, or even reviews.

Advertisement
  Learn how to remove ads

Reply
 
Thread Tools Display Modes
  #1  
Old 12-21-2008, 09:56 PM
h2ojunkie h2ojunkie is offline
Junior Member
 
Join Date: Oct 2006
Posts: 25
Geek Article and Review System License Holder Geek Auto-Linker Pro License Holder Geek Advertising Banner License Holder 
Default Suggestion - time to update the new page break BB code

For the most part the current BB code format for new page breaks works well.
Code:
[BREAK=New Page]
However, this can cause problems in some areas since there is no closing tag for the BB code.

For example:
http://www.thedogpound.org/forum/arc...php/t-188.html
Search the page for "Why did my vet not recommend glucosamine"

You will notice this line is preceded by a B (bold) bbcode tag that was not stripped from the page.

This is being caused by the fact that the gars BREAK bbcode has no closing tag.

After doing a little testing , I found a simple way to correct this issue by updating the gars BREAK bbcode to the following

Code:
[BREAK]New Page[/BREAK]
Maybe this can be considered for the next maintenance release.
Reply With Quote
  #2  
Old 12-23-2008, 03:16 AM
Morgan's Avatar
Morgan Morgan is offline
Administrator
 
Join Date: Jul 2006
Posts: 2,255
Geek Article and Review System License Holder GeekMart License Holder Geek Auto-Linker Pro License Holder Geek Advertising Banner License Holder Geek Gazette License Holder 
Default

Please create a post in this forum with what you are using so that I can see an example. Note that the BREAK tag should be used as follows:
Code:
Page One Text
[BREAK=page2]
Page Two Text
[BREAK=page3]
Page Three Text
__________________
Please use the forums for support, feature requests, and similar such things. Support does not include custom code, custom template edits, or third-party modifications. PMs and emails to me should be for private information only, such as login information. If you PM or email me a support question, chances are good that I'll ignore it. Thanks.
While the work or play is on, it is a lot of fun if while you are doing one you don't constantly feel that you ought to be doing the other. -- Franklin Pierce Adams
Reply With Quote
  #3  
Old 12-23-2008, 05:27 AM
h2ojunkie h2ojunkie is offline
Junior Member
 
Join Date: Oct 2006
Posts: 25
Geek Article and Review System License Holder Geek Auto-Linker Pro License Holder Geek Advertising Banner License Holder 
Default

Working as it should:
http://www.thevbgeek.com/showthread.php?p=27306

And the achier having problems stripping out all BB code because the BREAK tag doesn't have a closing tag:
http://www.thevbgeek.com/archive/index.php/t-4903.html

As you can see, the archive strips out the opening BREAK tag just fine.

However, the function that strips out BB code for the archive first looks for an opening tag, strips it, then looks for a matching closing tag and strips that.

Since the tags on this page appears as:
[b]some text[/b]
[break=new page]
[b]some more text[/b]

VB successfully strips out the first open/close B tags

Then strips the opening BREAK tag, skips the opening B tag (because it's looking for a closing tag match for BREAK.

Then it goes on to strip the closing B tag

The only workaround I found without editing VB core files is to change the format of the BREAK tag as I mentioned earlier so it also has a closing tag.

When the BB code appears on the page like this:
[b]some text[/b]
[break=new page][/break]
[b]some more text[/b]

OR:
[b]some text[/b]
[break]newpage[/break]
[b]some more text[/b]

Everything strips out fine. Of course, in the first example the closing tag ends up appearing in the full version and print version since GARS doesn't strip it out, and the second version isn't supported at all by gars but is probably the better way to do it since the 2nd version would allow the page title to show in the archive and in the printthread version without any further modifications.

P.S. This bug will only appear in the archive if there are BB code tags after the BREAK tag

Last edited by h2ojunkie; 12-23-2008 at 05:38 AM..
Reply With Quote
  #4  
Old 12-26-2008, 01:22 AM
Morgan's Avatar
Morgan Morgan is offline
Administrator
 
Join Date: Jul 2006
Posts: 2,255
Geek Article and Review System License Holder GeekMart License Holder Geek Auto-Linker Pro License Holder Geek Advertising Banner License Holder Geek Gazette License Holder 
Default

Thanks for the details. Will look into changing this in the next version.
__________________
Please use the forums for support, feature requests, and similar such things. Support does not include custom code, custom template edits, or third-party modifications. PMs and emails to me should be for private information only, such as login information. If you PM or email me a support question, chances are good that I'll ignore it. Thanks.
While the work or play is on, it is a lot of fun if while you are doing one you don't constantly feel that you ought to be doing the other. -- Franklin Pierce Adams
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
page break johnie42 Geek Article and Review System 2 08-20-2009 05:32 PM
Weird code on top of the page after installing GARS TCB Geek Article and Review System 1 06-21-2008 02:17 PM
<title> tag update for multi page articles Brent Geek Article and Review System 3 05-29-2006 06:37 PM
Best Way to Break Pages in 100 Page Article Biggles LLB Geek Article and Review System 10 05-19-2006 01:33 AM
all templates: page break layout corruption Bernd Geek Article and Review System 6 04-24-2006 11:01 AM


All times are GMT. The time now is 04:41 PM.


Powered by vBulletin® Version 3.8.5
Copyright ©2000 - 2017, Jelsoft Enterprises Ltd.