View Full Version : Module on all thread pages
cheesegrits
07-31-2008, 05:16 PM
Am I missing something obvious again?
I have a 'showthread' module, displaying 'above header'. Works great on the first page, but doesn't display on second and subsequent pages.
I need it to display on all showthread pages.
-- hugh
Morgan
08-01-2008, 02:28 AM
Is it one of the default GARS modules or a custom module? If one of the default GARS modules, which one? If custom, try temporarily placing one of the default GARS modules in that location and see if you experience the same effect. If things work okay with a default GARS modules, it might be the custom module, to which I couldn't give you an answer as I didn't code it. If it is a puny custom module, I might be able to help, but if it something complex, no promises there.
cheesegrits
08-01-2008, 03:59 PM
It's a custom module (actually it's a module to integrate Photoplog into GARS!). And I did indeed try a standard module, no joy.
The problem seems to be a design issue ... as far as I can tell GARS simply doesn't process modules on second and subsequent pages of threads, see process_postbit() in gars_class_page.php, around line 351:
// $$$ hugh
// if ($this->vb->GPC['pagenumber'] > 1)
if (0)
{
$return = ($this->templates['fp_prev'] ? $this->templates['fp_prev'] : 'postbit');
}
else
{
[... process modules ...]
}
With the modification above, my module shows up fine on all pages (although there's probably some little niggles with $postcount).
Any chance we can make this behaviour configurable in the next release?
-- hugh
Morgan
08-01-2008, 10:16 PM
My bad, I thought you were referring to pages in the article itself, missed the thread title. Correct, by default, thread pages past one do not show modules, maybe something/an on-off option for a future release.
cheesegrits
08-03-2008, 12:20 AM
My bad, I thought you were referring to pages in the article itself, missed the thread title. Correct, by default, thread pages past one do not show modules, maybe something/an on-off option for a future release.
That'd be great. I have quite a few uses for GARS in mind where modules would need to be on all pages of a thread, not just the one I'm working on for James & Susan.
I'll go ahead and add it as an option on my end. I think there's a few other places that need tweaking, mostly just cosmetic stuff to do with the number of posts on the page.
If there's any non-obvious gotchas, I'll let you know.
-- hugh
vBulletin® v3.8.5, Copyright ©2000-2012, Jelsoft Enterprises Ltd.