PDA

View Full Version : My GARS Beta 4 Buglist - Part 1

James Goddard
10-26-2005, 03:52 PM
This stuff mostly involves making the pages validate, however there is a fix for the articles not being at the top of the page on the forum view.

GARS_mod_container is not valid XHTML:
Line 1: height is not a valid attribute for <table>
Line 3: <img> tag that is repeated for each mod on the page has a fixed id string. ID's must be unique on a page.
Line 7: $id does not appear to be initialized causing duplicate id's
Correct template:

<table class="tborder" cellpadding="2" cellspacing="0" border="0" width="100%">
<thead><tr>
<td class="tcat" $columns><div style="white-space: nowrap;"><a style="float:$stylevar[right]" href="#top" onclick="return toggle_collapse('gar_$id')"><img src="$stylevar[imgdir_button]/collapse_tcat$vbcollapse[collapseimg_gar].gif" alt="" border="0" /></a>
$title</div>
</td>
</tr></thead>
<tbody style="$vbcollapse[collapseobj_gar]">
$bits
</tbody>
</table>








GARS_references is not valid XHTML:
Line 3: height is not a valid attribute for <table>
Line 5: <img> tag that is repeated on the page has a fixed id string. ID's must be unique on a page.
Line 9: $id does not appear to be initialized causing duplicate id's
Correct template:

<if condition="$stage == 'display'">
<br />
<table class="tborder" cellpadding="2" cellspacing="0" border="0" width="100%">
<thead><tr>
<td class="tcat" $columns><div style="white-space: nowrap;"><a style="float:$stylevar[right]" href="#top" onclick="return toggle_collapse('gar_$id')"><img src="$stylevar[imgdir_button]/collapse_tcat$vbcollapse[collapseimg_gar].gif" alt="" border="0" /></a>
References</div>
</td>
</tr></thead>
<tbody style="$vbcollapse[collapseobj_gar]">
<tr><td class="alt1">
$customvalue
</td></tr>
</tbody>
</table>
<else />
<fieldset class="fieldset">
<legend>$custom_title</legend>
<div style="padding:$stylevar[formspacer]px">
$custom_description<br />
<textarea name="$custom_name" id="$custom_name"
style="height:75px;width:364px;">$customvalue</textarea>
</div>
</fieldset>
</if>








GARS_threadbit is not valid XHTML:
Line 36: <img> tag is not closed with />
Line 41: height is not a valid attribute for <table>
Line 44: <hr> tag is not closed with />
Line 52: <div> has 2 classes
Several Lines: mismatched <tr><td></td></tr> combinations
Correct template:

<tr>
<td class="tcat" id="af_status_$thread[realthreadid]">
$thread[openclose_editable]
<img class="inlineimg" id="af_icon_$thread[realthreadid]" src="$stylevar[imgdir_statusicon]/post_<if condition="$thread['gar_feature']">new.gif" alt="Feature"<else />old.gif" alt=""</if> />
</td>
<td class="tcat" id="t$thread[threadid]" title="$thread[preview]" valign="top" width="100%" style="padding: 5px">
<div>
<span style="float:$stylevar[right]">
<if condition="$show['paperclip']"><img class="inlineimg" src="$stylevar[imgdir_misc]/paperclip.gif" alt="<phrase 1="$thread[attach]">$vbphrase[x_attachments]</phrase>" /></if>
<if condition="$show['subscribed']"><img class="inlineimg" src="$stylevar[imgdir_misc]/subscribed.gif" alt="$vbphrase[you_are_subscribed_to_this_thread]" /></if>
<if condition="$show['sticky']"><img class="inlineimg" src="$stylevar[imgdir_misc]/sticky.gif" alt="$vbphrase[sticky_thread]" /></if>
<if condition="$show['threadratings'] AND $show['threadrating']"><img class="inlineimg" src="$stylevar[imgdir_rating]/rating_$thread[rating].gif" border="0" alt="<phrase 1="$thread[votenum]" 2="$thread[voteavg]">$vbphrase[thread_rating_x_votes_y_average]</phrase>" /></if>
</span>
<if condition="$show['gotonewpost']"><a href="showthread.php?$session[sessionurl]goto=newpost&amp;t=$thread[threadid]"><img class="inlineimg" src="$stylevar[imgdir_button]/firstnew.gif" alt="$vbphrase[go_to_first_new_post]" border="0" /></a></if>
$thread[movedprefix]
$thread[typeprefix]
<a href="showthread.php?$session[sessionurl]t=$thread[threadid]$thread[highlight]"><if condition="$show['gotonewpost']"><strong>$thread[threadtitle]</strong><else />$thread[threadtitle]</if></a>
</div>
<if condition="$show['unsubscribe']">
<div class="smallfont">
<a href="newreply.php?$session[sessionurl]do=newreply&amp;t=$thread[threadid]">$vbphrase[reply]</a> |
<a href="subscription.php?$session[sessionurl]do=removesubscription&amp;return=ucp&amp;t=$thread[threadid]">$vbphrase[unsubscribe]</a>
</div>
</if>
<if condition="$show['inlinemod']">
<td class="tcat" align="right">
<input type="checkbox" name="tlist[$thread[realthreadid]]" id="tlist_$thread[realthreadid]" value="$thread[checkbox_value]" <if condition="$show['disabled']">disabled="disabled"</if> />
</td>
</if>
</td>
</tr>
<tr>
<td class="alt2" <if condition="$show['inlinemod']">colspan="3"<else />colspan="2"</if>>
<table cellpadding="0" cellspacing="0" border="0">
<tr>
<td class="alt2" align="center" rowspan="2" valign="top" style="padding: 10px;" >
<if condition="$thread['header_image']">
<a href="showthread.php?$session[sessionurl]t=$thread[threadid]$thread[highlight]"><img src="$thread[header_image]" border="0" style="border: 2px #000000;padding:2px;" alt="" /></a>
<else />
&nbsp;
</if>
</td>
<td class="alt1" title="$thread[preview]" width="100%" valign="top" style="padding: 10px;" >
<if condition="$thread[byline]">
<div class="smallfont">
$thread[byline]<hr/>
</div>
</if>
<div class="smallfont">
$thread[synopsis]
</div>
</td>
</tr>
<tr>
<td class="alt1" align="right" valign="bottom" >
<div class="smallfont"><div class="alt1">
<if condition="$show['guestuser']">
$vbphrase[GARS_posted_by] $thread[postusername]
<else />
<span style="cursor:pointer" onclick="window.open('member.php?$session[sessionurl]u=$thread[postuserid]')">posted by $thread[postusername]</span>
</if> - $vbphrase[GARS_last_activity] $thread[lastpostdate] <if condition="!$show['detailedtime']"><span class="time">$thread[lastposttime]</span></if>
<phrase 1="member.php?find=lastposter&amp;t=$thread[threadid]" 2="$thread[lastposter]">$vbphrase[by_x]</phrase> <a href="showthread.php?$session[sessionurl]goto=lastpost&amp;t=$thread[threadid]"><img class="inlineimg" src="$stylevar[imgdir_button]/lastpost.gif" alt="$vbphrase[go_to_last_post]" border="0" /></a>
</div></div>
</td>
</tr>
</table>
</td>
</tr>








GARS_threadbit_deleted is not valid XHTML:
Line 30: height is not a valid attribute for <table>
Correct template:

<tr>
<td class="tcat" id="t$thread[threadid]" title="$thread[preview]" valign="top" width="100%" colspan="2" style="padding: 5px">
<div>
<span style="float:$stylevar[right]">
<if condition="$show['paperclip']"><img class="inlineimg" src="$stylevar[imgdir_misc]/paperclip.gif" alt="<phrase 1="$thread[attach]">$vbphrase[x_attachments]</phrase>" /></if>
<if condition="$show['subscribed']"><img class="inlineimg" src="$stylevar[imgdir_misc]/subscribed.gif" alt="$vbphrase[you_are_subscribed_to_this_thread]" /></if>
<if condition="$show['sticky']"><img class="inlineimg" src="$stylevar[imgdir_misc]/sticky.gif" alt="$vbphrase[sticky_thread]" /></if>
<if condition="$show['threadratings'] AND $show['threadrating']"><img class="inlineimg" src="$stylevar[imgdir_rating]/rating_$thread[rating].gif" border="0" alt="<phrase 1="$thread[votenum]" 2="$thread[voteavg]">$vbphrase[thread_rating_x_votes_y_average]</phrase>" /></if>
</span>
<if condition="$show['gotonewpost']"><a href="showthread.php?$session[sessionurl]goto=newpost&amp;t=$thread[threadid]"><img class="inlineimg" src="$stylevar[imgdir_button]/firstnew.gif" alt="$vbphrase[go_to_first_new_post]" border="0" /></a></if>
$thread[movedprefix]
$thread[typeprefix]
<a href="showthread.php?$session[sessionurl]t=$thread[threadid]$thread[highlight]"><if condition="$show['gotonewpost']"><strong>$thread[threadtitle]</strong><else />$thread[threadtitle]</if></a>
</div>
<if condition="$show['unsubscribe']">
<div class="smallfont">
<a href="newreply.php?$session[sessionurl]do=newreply&amp;t=$thread[threadid]">$vbphrase[reply]</a> |
<a href="subscription.php?$session[sessionurl]do=removesubscription&amp;return=ucp&amp;t=$thread[threadid]">$vbphrase[unsubscribe]</a>
</div>
</if>
<if condition="$show['inlinemod']">
<td class="tcat" align="right">
<input type="checkbox" name="tlist[$thread[realthreadid]]" id="tlist_$thread[realthreadid]" value="$thread[checkbox_value]" <if condition="$show['disabled']">disabled="disabled"</if> />
</if>
</td>
</tr>
<tr>
<td class="alt2" <if condition="$show['inlinemod']">colspan="4"<else />colspan="3"</if>>
<table cellpadding="0" cellspacing="0" border="0"><tr>
<td class="alt1" title="$thread[preview]" width="100%" valign="top" style="padding: 10px;" >
<div class="smallfont"><phrase 1="member.php?$session[sessionurl]u=$thread[del_userid]" 2="$thread[del_username]">$vbphrase[thread_deleted_by_x]</phrase></div>
<if condition="$show['deletereason']">
<div class="smallfont">$vbphrase[reason]: <em>$thread[del_reason]</em></div>
</if>
</td>
<tr>
<td class="alt1" align="right" valign="bottom" >
<div class="smallfont" class="alt1">
<if condition="$show['guestuser']">
$vbphrase[GARS_posted_by] $thread[postusername]
<else />
<span style="cursor:pointer" onclick="window.open('member.php?$session[sessionurl]u=$thread[postuserid]')">posted by $thread[postusername]</span>
</if> - $vbphrase[GARS_last_activity] $thread[lastpostdate] <if condition="!$show['detailedtime']"><span class="time">$thread[lastposttime]</span></if>
<phrase 1="member.php?find=lastposter&amp;t=$thread[threadid]" 2="$thread[lastposter]">$vbphrase[by_x]</phrase> <a href="showthread.php?$session[sessionurl]goto=lastpost&amp;t=$thread[threadid]"><img class="inlineimg" src="$stylevar[imgdir_button]/lastpost.gif" alt="$vbphrase[go_to_last_post]" border="0" /></a>
</div>
</td>
</td></tr></table></td>
</tr>
</td>
</tr>
James Goddard
10-26-2005, 03:53 PM
GARS_tools is not valid XHTML:
Line 1: height is not a valid attribute for <table>
Line 8: alt is a required attribute for <img>
Line 9: alt is a required attribute for <img>
Line 10: missing <tr>
Line 33: </tbody> should be outside of </if>
Correct template:

<table class="tborder" cellpadding="2" cellspacing="0" border="0" width="100%">
<thead>
<tr>
<td class="tcat"><a style="float:$stylevar[right]" href="#top" onclick="return toggle_collapse('article_tools')"><img id="collapseimg_article_tools" src="$stylevar[imgdir_button]/collapse_tcat$vbcollapse[collapseimg_article_tools].gif" alt="" border="0" /></a>
<phrase 1="$post[GARS_text_capital]">$vbphrase[thread_tools]</phrase><a name="goto_threadtools"></a>
</td>
</tr>
</thead>
<tbody id="collapseobj_article_tools" style="$vbcollapse[collapseobj_article_tools]">
<if condition="$show['reputationlink']"><tr><td class="alt2" style="white-space: nowrap;font-size: 8pt;"><img class="inlineimg" border="0" src="$stylevar[imgdir_button]/reputation.gif" alt="" />*<a href="#" onclick="reputation($post[postid]); return false;"><phrase 1="$post[username]">$vbphrase[add_to_xs_reputation]</phrase></a></td></tr></if>
<if condition="$show['reportlink']"><tr><td class="alt2" style="white-space: nowrap;font-size: 8pt;"><img class="inlineimg" src="$stylevar[imgdir_button]/report.gif" border="0" alt="" /><a href="report.php?$session[sessionurl]p=$post[postid]" rel="nofollow">$vbphrase[report_bad_post]</a></td></tr></if>
<tr>
<td class="alt2" style="white-space: nowrap;font-size: 8pt;">
<img class="inlineimg" src="$stylevar[imgdir_button]/printer.gif" alt="$vbphrase[show_printable_version]" /> <a href="printthread.php?$session[sessionurl]t=$post[threadid]" accesskey="3">$vbphrase[show_printable_version]</a>
</td>
</tr>
<tr>
<td class="alt2" style="white-space: nowrap;font-size: 8pt;">
<img class="inlineimg" src="$stylevar[imgdir_button]/sendtofriend.gif" alt="$vbphrase[email_this_page]" /> <a href="sendmessage.php?$session[sessionurl]do=sendtofriend&amp;t=$post[threadid]">$vbphrase[email_this_page]</a>
</td>
</tr>
<if condition="$show['member']">
<tr>
<td class="alt2" style="white-space: nowrap;font-size: 8pt;">
<img class="inlineimg" src="$stylevar[imgdir_button]/subscribe.gif" alt="$vbphrase[subscription]" />
<if condition="$show['subscribed']">
<a href="subscription.php?$session[sessionurl]do=removesubscription&amp;t=$post[threadid]">$vbphrase[unsubscribe_to_this_thread]</a>
<else />
<a href="subscription.php?$session[sessionurl]do=addsubscription&amp;t=$post[threadid]">$vbphrase[subscribe_to_this_thread]</a>
</if>
</td>
</tr>
</if>
</tbody>
</table>









GARS_forumdisplay is not valid XHTML and does not display the threads at the top:
Line 81: adding valign="top" to the <tr> will fix the bug with the articles showing up in the middle of the page.
Line 137: </td> is mismatched
Correct template:

$stylevar[htmldoctype]
<html dir="$stylevar[textdirection]" lang="$stylevar[languagecode]">
<head>
$headinclude
<title>$foruminfo[title_clean]<if condition="$pagenumber>1"> - <phrase 1="$pagenumber">$vbphrase[page_x]</phrase></if> - $vboptions[bbtitle]</title>
<if condition="$show['inlinemod']"><script type="text/javascript" src="clientscript/vbulletin_inlinemod.js"></script></if>
</head>
<body>
$header
$navbar
<if condition="$show['forumslist']">
<!-- sub-forum list -->
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center" style="border-bottom-width:0px">
<tr>
<td class="tcat" width="100%">$vbphrase[subforums]<span class="normal"> : $foruminfo[title]</span></td>
<if condition="$show['forumsearch']">
<td class="vbmenu_control" id="forumsearch.subforums" nowrap="nowrap"><a href="search.php?$session[sessionurl]f=$foruminfo[forumid]" rel="nofollow">$vbphrase[search_this_forum]</a> <script type="text/javascript"> vbmenu_register("forumsearch.subforums"); </script></td>
</if>
</tr>
</table>
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
<thead>
<tr align="center">
<td class="thead">*</td>
<td class="thead" width="100%" align="$stylevar[left]">$vbphrase[forum]</td>
<td class="thead" width="175">$vbphrase[last_post]</td>
<td class="thead">$vbphrase[threads]</td>
<td class="thead">$vbphrase[posts]</td>
<if condition="$vboptions[showmoderatorcolumn]">
<td class="thead">$vbphrase[moderator]</td>
</if>
</tr>
</thead>
$forumbits
</table>
<br />
<!-- / sub-forum list -->
</if>
<if condition="$show['threadslist']">
<!-- threads list -->
<form action="inlinemod.php" method="post" id="inlinemodform">
<input type="hidden" name="url" value="$url" />
<input type="hidden" name="s" value="$session[sessionhash]" />
<input type="hidden" name="forumid" value="$forumid" />
<!-- controls above thread list -->
<table cellpadding="0" cellspacing="0" border="0" width="100%" style="margin-bottom:3px">
<tr valign="bottom">
<td class="smallfont"><if condition="$show['newthreadlink']"><a href="newthread.php?$session[sessionurl]do=newthread&amp;f=$foruminfo[forumid]" rel="nofollow"><img src="$stylevar[imgdir_button]/$stylevar[GARS_new_button]" alt="$vbphrase[post_new_thread]" border="0" /></a><else />*</if></td>
<if condition="$pagenav"><td align="$stylevar[right]">$pagenav</td></if>
</tr>
</table>
<if condition="$show[GARS_modposition1]">
$show[GARS_modposition1]
</if>
<!-- / controls above thread list -->
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center" style="border-bottom-width:0px">
<tr>
<td class="tcat" width="100%" <if condition="$show[GARS_columns]">colspan="$show[GARS_columns]"</if>>$vbphrase[threads_in_forum]<span class="normal"> : $foruminfo[title]</span></td>
<td class="vbmenu_control" id="forumtools" nowrap="nowrap"><a href="$show[nojs_link]#goto_forumtools" rel="nofollow">$vbphrase[forum_tools]</a> <script type="text/javascript"> vbmenu_register("forumtools"); </script></td>
<if condition="$show['forumsearch']">
<td class="vbmenu_control" id="forumsearch" nowrap="nowrap"><a href="$show[nojs_link]#goto_forumsearch" rel="nofollow">$vbphrase[search_this_forum]</a> <script type="text/javascript"> vbmenu_register("forumsearch"); </script></td>
<if condition="$show['inlinemod']">
<if condition="$show['popups']">
<td class="vbmenu_control" id="imod" align="center"> <script type="text/javascript"> vbmenu_register('imod'); </script> </td>
<else />
<td class="thead" align="center">
<input type="checkbox" name="allbox" id="checkall_all" title="$vbphrase[check_uncheck_all]" onclick="inlineMod.check_all()" />
</td>
</if>
</if>
</if>
</tr>
</table>
<table cellpadding="0" cellspacing="0" border="0" width="100%" align="center" id="threadslist">
<if condition="$show[GARS_columns]">
<tr valign="top">
<if condition="$show[GARS_modposition2]">
<td valign="top" width="170px" style="padding-top:10px;">
$show[GARS_modposition2]
</td><td style="padding:10px;">
<else />
<td style="padding:10px;">
</if>
<table border="0" class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]">
</if>
<if condition="$announcebits">
<tr><td class="alt1" <if condition="$show['inlinemod']">colspan="4"</if>><table border="0" width="100%">
$announcebits
</table></td></tr>
</if>
<if condition="$show['search_engine']">
<if condition="$show['threadicons']">
<td class="thead" colspan="2" >*</td>
<else />
<td class="thead">*</td>
</if>
<td class="thead" width="100%">
<if condition="$show['threadratings']"><span style="float:$stylevar[right]">$vbphrase[rating]</span></if>
$vbphrase[thread] / $vbphrase[thread_starter]
</td>
<td class="thead" width="150" align="center" nowrap="nowrap"><span style="white-space:nowrap">$vbphrase[last_post]</span></td>
<td class="thead" align="center" nowrap="nowrap"><span style="white-space:nowrap">$vbphrase[replies]</span></td>
<td class="thead" align="center" nowrap="nowrap"><span style="white-space:nowrap">$vbphrase[views]</span></td>
</if>
<if condition="$show['threads']">
<!-- show threads -->
<if condition="$show['stickies']">
$threadbits_sticky
</if>
$threadbits
<!-- end show threads -->
<else />
<!-- show no threads message -->
<tr>
<td class="alt1" colspan="$foruminfo[bottomcolspan]" align="center">
<div style="padding: 16px">
<if condition="$show['noposts']"><strong>$vbphrase[no_posts_in_this_forum]</strong><else /><strong><phrase 1="$daysprune">$vbphrase[no_posts_last_x_days_forum]</phrase></strong><br />
<span class="smallfont">$vbphrase[try_controls_below_for_older_posts]</span></if>
</div>
</td>
</tr>
<!-- end show no threads message -->
</if>
</table>
<if condition="$show[GARS_columns]">
<if condition="$show[GARS_modposition3]">
</td><td valign="top" width="170px" style="padding-top:10px;">
$show[GARS_modposition3]
</td>
</if></tr></table>
</if>
<!-- controls below thread list -->
<table cellpadding="0" cellspacing="0" border="0" width="100%" style="margin-top:3px">
<tr valign="top">
<td class="smallfont"><if condition="$show['newthreadlink']"><a href="newthread.php?$session[sessionurl]do=newthread&amp;f=$foruminfo[forumid]" rel="nofollow"><img src="$stylevar[imgdir_button]/$stylevar[GARS_new_button]" alt="$vbphrase[post_new_thread]" border="0" /></a><else />*</if></td>
<if condition="$pagenav OR $show['inlinemod']">
<td class="smallfont" align="$stylevar[right]">$pagenav
<if condition="$show['inlinemod']">
<br /><em>$vbphrase[moderation]</em>
<select name="do">
<optgroup label="$vbphrase[option]">
<if condition="$show['deletethread']">
<option value="deletethread">$vbphrase[delete_threads]</option>
<option value="undeletethread">$vbphrase[undelete_threads]</option>
</if>
<if condition="$show['openthread']">
<option value="open">$vbphrase[open_threads]</option>
<option value="close">$vbphrase[close_threads]</option>
</if>
<if condition="$show['approvethread']">
<option value="approvethread">$vbphrase[approve_threads]</option>
<option value="unapprovethread">$vbphrase[unapprove_threads]</option>
</if>
<if condition="$show['movethread']">
<option value="stick">$vbphrase[stick_threads]</option>
<option value="unstick">$vbphrase[unstick_threads]</option>
<option value="movethread">$vbphrase[move_threads]</option>
<option value="mergethread">$vbphrase[merge_threads]</option>
</if>
</optgroup>
<optgroup label="____________________">
<option value="clearthread">$vbphrase[clear_thread_list]</option>
</optgroup>
</select>
<input type="submit" class="button" id="inlinego" value="$vbphrase[go]" />
<script type="text/javascript">
<!--
inlineMod = new vB_Inline_Mod('inlineMod', 'thread', 'inlinemodform', '$vbphrase[go_x]');
//-->
</script>
</if>
</td>
</if>
</tr>
</table>
<!-- / controls below thread list -->
</form>
<br />


<!-- Active Users in this Forum (and sub-forums) and Moderators -->
<form action="forumdisplay.php" method="get">
<input type="hidden" name="s" value="$session[sessionhash]" />
<input type="hidden" name="f" value="$forumid" />
<input type="hidden" name="page" value="$pagenumber" />
<input type="hidden" name="pp" value="$perpage" />
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
<tr>
<td class="tcat">$vbphrase[display_options]</td>
<if condition="$show['activeusers']">
<td class="tcat">$vbphrase[currently_active_users]</td>
</if>
<if condition="$show['moderators']">
<td class="tcat">$vbphrase[moderators]</td>
</if>
</tr>
<tr>
<td class="thead"><phrase 1="$limitlower" 2="$limitupper" 3="$totalthreads">$vbphrase[showing_threads_x_to_y_of_z]</phrase></td>
<if condition="$show['activeusers']">
<td class="thead">$totalonline (<phrase 1="$numberregistered" 2="$numberguest">$vbphrase[x_members_y_guests]</phrase>)</td>
</if>
<if condition="$show['moderators']">
<td class="thead">$vbphrase[moderators] : $totalmods</td>
</if>
</tr>
<tr valign="top">
<td class="alt1">
<table cellpadding="0" cellspacing="1" border="0" width="auto">
<tr>
<td class="smallfont" style="padding-right:6px">$vbphrase[sorted_by]</td>
<td><select name="sort">
<option value="title" $sort[title]>$vbphrase[thread_title]</option>
<option value="lastpost" $sort[lastpost]>$vbphrase[last_post_time]</option>
<option value="replycount" $sort[replycount]>$vbphrase[number_of_replies]</option>
<option value="views" $sort[views]>$vbphrase[number_of_views]</option>
<option value="postusername" $sort[postusername]>$vbphrase[thread_starter]</option>
<if condition="$show['threadratings']"><option value="voteavg" $sort[voteavg]>$vbphrase[thread_rating]</option></if>
</select></td>
<td class="smallfont" style="padding-right:6px; padding-left:12px">$vbphrase[sort_order]</td>
<td><select name="order">
<option value="asc" $order[asc]>$vbphrase[ascending]</option>
<option value="desc" $order[desc]>$vbphrase[descending]</option>
</select></td>
</tr>
<tr>
<td class="smallfont" style="padding-right:6px">$vbphrase[from_the]</td>
<td><select name="daysprune">
<option value="1" $daysprunesel[1]>$vbphrase[last_day]</option>
<option value="2" $daysprunesel[2]>$vbphrase[last_2_days]</option>
<option value="7" $daysprunesel[7]>$vbphrase[last_week]</option>
<option value="10" $daysprunesel[10]>$vbphrase[last_10_days]</option>
<option value="14" $daysprunesel[14]>$vbphrase[last_2_weeks]</option>
<option value="30" $daysprunesel[30]>$vbphrase[last_month]</option>
<option value="45" $daysprunesel[45]>$vbphrase[last_45_days]</option>
<option value="60" $daysprunesel[60]>$vbphrase[last_2_months]</option>
<option value="75" $daysprunesel[75]>$vbphrase[last_75_days]</option>
<option value="100" $daysprunesel[100]>$vbphrase[last_100_days]</option>
<option value="365" $daysprunesel[365]>$vbphrase[last_year]</option>
<option value="-1" $daysprunesel[all]>$vbphrase[beginning]</option>
</select></td>
<td colspan="2" align="$stylevar[right]"><input type="submit" class="button" value="$vbphrase[show_threads]" /></td>
</tr>
</table>
</td>
<if condition="$show['activeusers']">
<td class="alt1"><div class="smallfont">$activeusers</div></td>
</if>
<if condition="$show['moderators']">
<td class="alt1"><div class="smallfont">$moderatorslist*</div></td>
</if>
</tr>
</table>
</form>
<!-- End Active Users in this Forum (and sub-forums) and Moderators -->
<if condition="$show['popups']">
<br />
<!-- popup menu contents -->

<!-- forum tools menu -->
<div class="vbmenu_popup" id="forumtools_menu" style="display:none">
<form action="moderator.php" method="post" name="forumadminform">
<table cellpadding="4" cellspacing="1" border="0">
<tr><td class="thead">Order by<a name="goto_forumtools"></a></td></tr>
<if condition="$show['threadratings']"><tr><td class="vbmenu_option">$sortarrow[voteavg]<a href="$sorturl&amp;order=desc&amp;sort=voteavg" rel="nofollow">$vbphrase[rating]</a></td></tr></if>
<tr><td class="vbmenu_option">$sortarrow[title]<a href="$sorturl&amp;order=asc&amp;sort=title" rel="nofollow">$vbphrase[thread]</a></td></tr>
<tr><td class="vbmenu_option">$sortarrow[postusername]<a href="$sorturl&amp;order=asc&amp;sort=postusername" rel="nofollow">$vbphrase[thread_starter]</a></td></tr>
<tr><td class="vbmenu_option">$sortarrow[lastpost]<a href="$sorturl&amp;order=desc&amp;sort=lastpost" rel="nofollow">$vbphrase[last_post]</a></td></tr>
<tr><td class="vbmenu_option">$sortarrow[replycount]<a href="$sorturl&amp;order=desc&amp;sort=replycount" rel="nofollow">$vbphrase[replies]</a></td></tr>
<tr><td class="vbmenu_option">$sortarrow[views]<a href="$sorturl&amp;order=desc&amp;sort=views" rel="nofollow">$vbphrase[views]</a></td></tr>
<tr><td class="thead">$vbphrase[forum_tools]<a name="goto_forumtools"></a></td></tr>
<if condition="$show['newthreadlink']"><tr><td class="vbmenu_option"><a href="newthread.php?$session[sessionurl]do=newthread&amp;f=$foruminfo[forumid]" rel="nofollow">$vbphrase[post_a_new_thread]</a></td></tr></if>
<tr><td class="vbmenu_option"><a href="forumdisplay.php?$session[sessionurl]do=markread&amp;f=$foruminfo[forumid]" rel="nofollow">$vbphrase[mark_this_forum_read]</a></td></tr>
<tr><td class="vbmenu_option"><a href="subscription.php?$session[sessionurl]do=addsubscription&amp;f=$foruminfo[forumid]" rel="nofollow">$vbphrase[subscribe_to_this_forum]</a></td></tr>
<tr><td class="vbmenu_option"><a href="forumdisplay.php?$session[sessionurl]f=$foruminfo[parentid]" rel="nofollow">$vbphrase[view_parent_forum]</a></td></tr>
<if condition="$show['adminoptions']">
<tr>
<td class="thead">$vbphrase[admin_tools]<a name="goto_forumadmin"></a></td>
</tr>
<tr>
<td class="vbmenu_option" title="nohilite">
<div><label for="fa_mpo"><input type="radio" name="do" id="fa_mpo" value="modposts" checked="checked" />$vbphrase[view_posts_queue]</label></div>
<div><label for="fa_mat"><input type="radio" name="do" id="fa_mat" value="modattach" />$vbphrase[view_attachment_queue]</label></div>
<div><label for="fa_mov"><input type="radio" name="do" id="fa_mov" value="move" />$vbphrase[massmove_threads]</label></div>
<div><label for="fa_prn"><input type="radio" name="do" id="fa_prn" value="prune" />$vbphrase[massprune_threads]</label></div>
<if condition="$show['addmoderator']">
<div><label for="fa_amd"><input type="radio" name="do" id="fa_amd" value="addmoderator" />$vbphrase[add_moderator]</label></div>
</if>
</td>
</tr>
<tr>
<td class="vbmenu_option" title="nohilite" align="center">
<input type="hidden" name="s" value="$session[sessionhash]" />
<input type="hidden" name="f" value="$forumid" />
<input type="submit" class="button" value="$vbphrase[perform_action]" />
</td>
</tr>
</if>
</table>
</form>
</div>
<!-- / forum tools menu -->
<!-- inline mod menu -->
<if condition="$show['inlinemod']">
<div class="vbmenu_popup" id="imod_menu" style="display:none" align="$stylevar[left]">
$threadadmin_imod_menu_thread
</div>
</if>
<!-- / inline mod menu -->
<!-- / popup menu contents -->
<else />
<!-- controls for non-popup browsers -->

<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center" style="border-top-width:0px">
<tr>
<td class="thead">$vbphrase[forum_tools]<a name="goto_forumtools"></a></td>
<td class="thead">$vbphrase[search_this_forum]<a name="goto_forumsearch"></a></td>
</tr>
<tr valign="top">
<!-- forum tools -->
<td class="alt1">
<div class="smallfont">
<div><img class="inlineimg" src="$stylevar[imgdir_button]/subscribe.gif" alt="$vbphrase[mark_this_forum_read]" vspace="1" /> <a href="forumdisplay.php?$session[sessionurl]do=markread&amp;f=$foruminfo[forumid]" rel="nofollow">$vbphrase[mark_this_forum_read]</a></div>
<if condition="$show['member']"><div><img class="inlineimg" src="$stylevar[imgdir_button]/subscribe.gif" alt="$vbphrase[subscription]" vspace="1" /> <a href="subscription.php?$session[sessionurl]do=addsubscription&amp;f=$foruminfo[forumid]" rel="nofollow">$vbphrase[subscribe_to_this_forum]</a></div></if>
<div><img class="inlineimg" src="$stylevar[imgdir_button]/subscribe.gif" alt="$vbphrase[view_parent_forum]" vspace="1" /> <a href="forumdisplay.php?$session[sessionurl]f=$foruminfo[parentid]" rel="nofollow">$vbphrase[view_parent_forum]</a></div>
</div>
</td>
<!-- / forum tools -->
<!-- search this forum -->
<td class="alt1">
<form action="search.php" method="post">
<div class="smallfont">
<input type="hidden" name="s" value="$session[sessionhash]" />
<input type="hidden" name="do" value="process" />
<input type="hidden" name="do" value="quicksearch" />
<input type="hidden" name="forumchoice[]" value="$forumid" />
<input type="hidden" name="childforums" value="1" />
<strong>$vbphrase[search_this_forum]</strong> :<br />
<input type="text" class="bginput" name="query" size="20" style="width:175px" />$gobutton<br />
<a href="search.php?$session[sessionurl]f=$forumid" rel="nofollow">$vbphrase[advanced_search]</a>
</div>
</form>
</td>
<!-- / search this forum -->
</tr>
</table>
<br />

<!-- / controls for non-popup browsers -->
</if>
<if condition="$show['ajax_js']">
<script type="text/javascript" src="clientscript/vbulletin_ajax_threadslist.js"></script>
<script type="text/javascript">
<!--
vB_AJAX_Threadlist_Init('threadslist');
//-->
</script>
<script type="text/javascript" src="./geek/gars/clientscript/GARS_ajax_af.js"></script>
<script type="text/javascript">
<!--
GARS_AJAX_af_Init('threadslist');
//-->
</script>
</if>
<!-- ############## END THREADS LIST ############## -->
</if>
<if condition="$show['popups'] AND $show['forumsearch']">
<!-- forum search menu -->
<div class="vbmenu_popup" id="forumsearch_menu" style="display:none">
<form action="search.php" method="post">
<table cellpadding="4" cellspacing="1" border="0">
<tr>
<td class="thead">$vbphrase[search_this_forum]<a name="goto_forumsearch"></a></td>
</tr>
<tr>
<td class="vbmenu_option" title="nohilite">
<input type="hidden" name="s" value="$session[sessionhash]" />
<input type="hidden" name="do" value="process" />
<input type="hidden" name="forumchoice[]" value="$forumid" />
<input type="hidden" name="childforums" value="1" />
<input type="text" class="bginput" name="query" size="20" />$gobutton<br />
</td>
</tr>
<tr>
<td class="vbmenu_option"><a href="search.php?$session[sessionurl]f=$forumid" rel="nofollow">$vbphrase[advanced_search]</a></td>
</tr>
</table>
</form>
</div>
<!-- / forum search menu -->
</if>
<!-- icon key -->
<if condition="$show['threadslist']">
<table cellpadding="2" cellspacing="0" border="0">
<tr>
<td><img src="$stylevar[imgdir_statusicon]/thread_new.gif" alt="$vbphrase[new_posts]" border="0" /></td>
<td class="smallfont">$vbphrase[new_posts]</td>
<if condition="$vboptions['usehotthreads']">
<td><img src="$stylevar[imgdir_statusicon]/thread_hot_new.gif" alt="<phrase 1="$vboptions[hotnumberposts]" 2="$vboptions[hotnumberviews]">$vbphrase[more_than_x_replies_or_y_views]</phrase>" border="0" /></td>
<td class="smallfont">$vbphrase[hot_thread_with_new_posts]</td>
<else />
<td colspan="2">*</td>
</if>
</tr>
<tr>
<td><img src="$stylevar[imgdir_statusicon]/thread.gif" alt="$vbphrase[no_new_posts]" border="0" /></td>
<td class="smallfont">$vbphrase[no_new_posts]</td>
<if condition="$vboptions['usehotthreads']">
<td><img src="$stylevar[imgdir_statusicon]/thread_hot.gif" alt="<phrase 1="$vboptions[hotnumberposts]" 2="$vboptions[hotnumberviews]">$vbphrase[more_than_x_replies_or_y_views]</phrase>" border="0" /></td>
<td class="smallfont">$vbphrase[hot_thread_with_no_new_posts]</td>
<else />
<td colspan="2">*</td>
</if>
</tr>
<tr>
<td><img src="$stylevar[imgdir_statusicon]/thread_lock.gif" alt="$vbphrase[closed_thread]" border="0" /></td>
<td class="smallfont">$vbphrase[thread_is_closed]</td>
<if condition="$show['dotthreads']">
<td><img src="$stylevar[imgdir_statusicon]/thread_dot.gif" alt="$vbphrase[thread_contains_a_message_written_by_you]" border="0" /></td>
<td class="smallfont">$vbphrase[you_have_posted_in_this_thread]</td>
<else />
<td colspan="2">*</td>
</if>
</tr>
</table>
<else />
<table cellpadding="0" cellspacing="2" border="0" width="100%">
<tr valign="bottom">
<td>
<table cellpadding="2" cellspacing="0" border="0">
<tr>
<td><img src="$stylevar[imgdir_statusicon]/forum_new.gif" alt="$vbphrase[contains_new_posts]" border="0" /></td>
<td class="smallfont">* $vbphrase[forum_contains_new_posts]</td>
</tr>
<tr>
<td><img src="$stylevar[imgdir_statusicon]/forum_old.gif" alt="$vbphrase[contains_no_new_posts]" border="0" /></td>
<td class="smallfont">* $vbphrase[forum_contains_no_new_posts]</td>
</tr>
<tr>
<td><img src="$stylevar[imgdir_statusicon]/forum_old_lock.gif" alt="$vbphrase[a_closed_forum]" border="0" /></td>
<td class="smallfont">* $vbphrase[forum_is_closed_for_posting]</td>
</tr>
</table>
</td>
</tr>
</table>
</if>
<!-- / icon key -->
<!-- forum rules & forum jump -->
<table cellpadding="0" cellspacing="0" border="0" width="100%" align="center">
<tr valign="top">
<td width="100%">
<div class="smallfont">*</div>
<if condition="$show['threadslist']">$forumrules</if>
</td>
<td>
$forumjump
<if condition="!$show['popups'] AND $show['adminoptions']">
<br />
<form action="moderator.php" method="get">
<input type="hidden" name="s" value="$session[sessionhash]" />
<input type="hidden" name="f" value="$forumid" />
<div class="smallfont"><strong>$vbphrase[admin_tools]</strong> :</div>
<select name="do" onchange="this.form.submit();">
<optgroup label="$vbphrase[admin_tools]">
<option value="modposts" selected="selected">$vbphrase[view_posts_queue]</option>
<option value="modattach">$vbphrase[view_attachment_queue]</option>
<option value="move">$vbphrase[mass_move]</option>
<option value="prune">$vbphrase[mass_prune]</option>
<if condition="$show['addmoderator']">
<option value="addmoderator">$vbphrase[add_moderator]</option>
</if>
</optgroup>
</select>$gobutton
</form>
</if>
</td>
</tr>
</table>
<!-- / forum rules & forum jump -->
$footer
</body>
</html>









GARS_gallery)bit is not valid XHTML:
Line 4: alt is a required attribute for <img>
Correct template:

<td width="$typeinfo[image_width]" height="$typeinfo[image_height]" align="center" cellpadding="4px">
<td width="$typeinfo[image_width]" height="$typeinfo[image_height]" align="center" valign="top" cellpadding="4px">
<if condition="!$skipit">
<img src="$gallery_image" border="2" alt="" /><br />
<input type="radio" name="GARS_header_image" value="$gallery_image" id="rb_imageid_$x" tabindex="$x" $selected />
<else />
*
</if>
</td>









GARS_pb is not valid XHTML:
Line 28: alt is a required attribute for <img>
Line 44: nowrap should be nowrap="nowrap"
Correct template:

<!-- Article #$post[postid] -->
<if condition="$show['spacer']">
$spacer_open
<div id="edit$post[postid]" style="padding:0px 0px $stylevar[cellpadding]px 0px">
</if>
<table class="tborder" id="post$post[postid]" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
<!-- GAR -->
<if condition="$post['GARS_modposition1']">
<tr>
<td class="alt1" valign="middle" align="center" colspan="$post[GARS_columns]">
$post[GARS_modposition1]
</td>
</tr>
</if>
<if condition="$show['inlinemod']">
<tr>
<td class="tcat" align="right" colspan="$post[GARS_columns]">
<input type="checkbox" name="plist[$postid]" id="plist_$postid" style="float:right; padding:0px; margin:0px 0px 0px 0px" value="$post[checkbox_value]" onclick="inlineMod.toggle(this)" />
</td>
</tr>
</if>
<tr>
<td class="alt2" align="left" style="padding:10px 10px 10px 10px" colspan="$post[GARS_columns]" $post[scrolltothis]>
<table cellpadding="0" cellspacing="0" width="100%">
<tr>
<if condition="$post['GARS_header_image']">
<td style="padding:10px 10px 10px 10px">
<img src="$post[GARS_header_image]" border="2" alt="" />
</td>
<else />
<td>*</td>
</if>
<td width="100%">
<span class="bigusername">
$post[title]
</span>
<br />
<span class="smallfont">
<if condition="$post['GARS_byline']">$post[GARS_byline]<br /></if>
$vbphrase[GARS_posted_by] <a href="member.php?u=$post[userid]">$post[musername]</a><br />
$vbphrase[posted] $post[postdate]
</span>
</td>
<td align="right" valign="top" nowrap>
<span style="font-size:12px; font-family:tahoma, verdana, geneva, lucida, 'lucida grande', arial, helvetica, sans-serif;">
$post[GARS_modposition2]
<br />
</span>
</td>
</tr>
</table>
</td>
</tr>
<if condition="$post['GARS_modposition3']">
<tr>
<td class="alt1" valign="middle" align="center" colspan="$post[GARS_columns]">
$post[GARS_modposition3]
</td>
</tr>
</if>
<tr>
<if condition="$post['GARS_modposition4']">
<td class="alt1" valign="top" width="200px">
$post[GARS_modposition4]
</td>
</if>
<td class="alt1" valign="top">
<!-- message -->
<div>$post[message]</div>
<!-- / message -->
</td>
<if condition="$post['GARS_modposition5']">
<td class="alt1" valign="top" width="200px">
$post[GARS_modposition5]
</td>
</if>
</tr>
$post[GARS_navigation]
<tr>
<td colspan="$post[GARS_columns]" class="alt1">
<if condition="$post['signature']">
<!-- sig -->
<div>
__________________<br />
$post[signature]
</div>
<!-- / sig -->
</if>
<div align="$stylevar[right]">
<!-- controls -->
<if condition="$post['editlink']">
<a href="$post[editlink]"><img src="$stylevar[imgdir_button]/edit.gif" alt="$vbphrase[edit_delete_message]" border="0" /></a>
</if>
<if condition="$post['forwardlink']">
<a href="$post[forwardlink]"><img src="$stylevar[imgdir_button]/forward.gif" alt="$vbphrase[forward_message]" border="0" /></a>
</if>
<if condition="$post['replylink']">
<a href="$post[replylink]"><img src="$stylevar[imgdir_button]/<if condition="$post['forwardlink']">reply_small<else />quote</if>.gif" alt="$vbphrase[reply_with_quote]" border="0" /></a>
</if>
<if condition="$show['quickreply'] AND !$show['threadedmode']">
<a href="$post[replylink]" rel="nofollow" id="qr_$post[postid]" onclick="return false"><img src="$stylevar[imgdir_button]/quickreply.gif" alt="$vbphrase[quick_reply_to_this_message]" border="0" /></a>
</if>
<!-- / controls -->
</div>
<!-- message, attachments, sig -->
</td>
</tr>
</table>
<if condition="$post['GARS_modposition6']">
$post[GARS_modposition6]
</if>
<if condition="$show['spacer']">
</div>
$spacer_close
</if>
<!-- / Article #$post[postid] -->
James Goddard
10-26-2005, 03:54 PM
GARS_preview_pb is not valid XHTML:
Line 19: alt is a required attribute for <img>
Correct template:

<!-- Article #$post[postid] -->
<if condition="$show['spacer']">
$spacer_open
<div id="edit$post[postid]" style="padding:0px 0px $stylevar[cellpadding]px 0px">
</if>
<table class="tborder" id="post$post[postid]" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
<!-- Articles -->
<tr>
<td class="alt2" align="left" style="padding:10px 10px 10px 10px">
<table cellpadding="0" cellspacing="0" width="100%">
<tr>
<if condition="$show['avatar'] AND $post['GARS_header_image']==''">
<td style="padding:10px 10px 10px 10px">
<a href="member.php?$session[sessionurl]u=$post[userid]"><img src="$avatarurl" alt="<phrase 1="$post[username]">$vbphrase[xs_avatar]</phrase>" border="0" /></a>
</td>
<else />
<td style="padding:10px 10px 10px 10px">
<if condition="$post[GARS_header_image]">
<img src="$post[GARS_header_image]" border="2" alt="" />
<else />
&nbsp;
</if>
</td>
</if>
<td width="100%">
<span class="bigusername">
$post[title]
</span>
<br />
<span class="smallfont">
<if condition="$post[GARS_byline]">$post[GARS_byline]<br /></if>
$vbphrase[GARS_posted_by] <a href="member.php?u=$post[userid]">$post[musername]</a><br />
$vbphrase[posted] $post[postdate]
</span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="alt1" valign="top">
<!-- message -->
<div>$post[message]</div>
<!-- / message -->
</td>
</tr>
<tr>
<td class="alt1">
<div align="$stylevar[right]">
<!-- controls -->
<if condition="$post[editlink]">
<a href="$post[editlink]"><img src="$stylevar[imgdir_button]/edit.gif" alt="$vbphrase[edit_delete_message]" border="0" /></a>
</if>
<if condition="$post[forwardlink]">
<a href="$post[forwardlink]"><img src="$stylevar[imgdir_button]/forward.gif" alt="$vbphrase[forward_message]" border="0" /></a>
</if>
<if condition="$show['quickreply'] AND !$show['threadedmode']">
<a href="$post[replylink]" rel="nofollow" id="qr_$post[postid]" onclick="return false"><img src="$stylevar[imgdir_button]/quickreply.gif" alt="$vbphrase[quick_reply_to_this_message]" border="0" /></a>
</if>
<!-- / controls -->
</div>
<!-- message, attachments, sig -->
</td>
</tr>
</table>
<if condition="$show['spacer']">
</div>
$spacer_close
</if>
<!-- / Article #$post[postid] -->





mods/featured.php produces invalid XHTML:
Line 64: alt is a required attribute for <img>
Line 64: </a></strong> should be </strong></a>
The Geek
10-26-2005, 04:27 PM
Wow. Thanks for that. Ill try to fold all this in to an update.

XHTML validato nwill be the death of me :)
eko
10-26-2005, 04:28 PM
thanks james updated them on my site :)
Nutz
10-26-2005, 04:41 PM
I'm sure Geek loves you for this ;)

Thanks,
Mat
James Goddard
10-26-2005, 04:49 PM
I'm sure Geek loves you for this ;)

Thanks,
Mat

Well I don't think he would have appreciated it if I just said "dude, the pages don't validate".

;)
eko
10-26-2005, 04:50 PM
Well I don't think he would have appreciated it if I just said "dude, the pages don't validate".

;)
I dont think any of us would have appriciated that

but heres a hug from all of us now :)
Nutz
10-26-2005, 04:54 PM
Well while we at it; most if not all the collapse buttons don't work :)

Thanks,
Mat

EDIT: I missed out the "don't"
The Geek
10-26-2005, 05:17 PM
Yes, collapse buttons is a known issue I'm hoping to resolve before next release.

Ill be looking at doing a clean up interim release (kind of a Beta 4.5) within the next 2 days. It looks like most key issues have been sorted, its now down to ironing out the last known issues. Then RC! :)

I appreciate everyones involvement, help and support. I'm really pumped about how this is coming together. My mind keeps exploding with possibilities ;)